AWS v7 Provider upgrade #6259
AWS v7 Provider upgrade #6259
Conversation
jamesgibbons92
force-pushed
the
aws-provider-7-12
branch
from
7ecfba8 to
0cd4502
Compare
jamesgibbons92
force-pushed
the
aws-provider-7-12
branch
from
7cdee66 to
3f57e52
Compare
jamesgibbons92
changed the title
|
Draft message for release notes:
|
|
One thing to consider, adding support for |
jamesgibbons92
force-pushed
the
aws-provider-7-12
branch
from
3f57e52 to
79c8374
Compare
|
I hope we can push on this PR as a lot of features are blocked by it 👍 |
jamesgibbons92
force-pushed
the
aws-provider-7-12
branch
from
79c8374 to
bd42373
Compare
|
@vimtor Now that pulumi has been merged I've updated this PR so it's good to review now. |
jamesgibbons92
force-pushed
the
aws-provider-7-12
branch
from
9120021 to
9bc91fa
Compare
|
Would love for this to be merged, it's key for my project, and I've switched to using this branch as my base. |
vimtor
left a comment
vimtor
left a comment
There was a problem hiding this comment.
hey @jamesgibbons92
i left a couple of minor comments about the migration steps
everything else seems to be working. great job!
will be testing more examples today to see if they still work
| "", | ||
| "```bash frame=\"none\"", | ||
| "sst deploy --refresh", | ||
| "```", | ||
| "Pass --refresh flag to refresh your state resources before deploying any changes.", | ||
| "This is useful for making sure your state reflects your cloud resources accurately before applying updates.", |
There was a problem hiding this comment.
thinking about what's the difference between sst deploy --refresh and sst refresh i discovered that the refresh command is broken in this pr:
default_7_12_0 pulumi:providers:aws
pulumi:providers:aws resource 'default_7_12_0' has a problem: Missing region information
Make sure you have set your AWS region, e.g. `pulumi config set aws:region us-west-2`.
regardless of whether we need this new flag, the user should be able to do:
sst refreshsst deploy
to upgrade their state right? @jamesgibbons92
if that's the case we might want to keep it simple and don't introduce new flags
| providerName: "aws", | ||
| fromVersion: "6.0.0", | ||
| toVersion: "7.0.0", | ||
| message: "Detected AWS provider upgrade to v7.\n\nUpgrading from v6 to v7 introduces some breaking changes and requires state migration before deploying. Refer to the SST release notes and the pulumi migration guide to make the relevent changes before deploying: https://www.pulumi.com/registry/packages/aws/how-to-guides/7-0-migration \n\nThis notice will clear after migrating your state", |
There was a problem hiding this comment.
| message: "Detected AWS provider upgrade to v7.\n\nUpgrading from v6 to v7 introduces some breaking changes and requires state migration before deploying. Refer to the SST release notes and the pulumi migration guide to make the relevent changes before deploying: https://www.pulumi.com/registry/packages/aws/how-to-guides/7-0-migration \n\nThis notice will clear after migrating your state", | |
| message: "Detected AWS provider upgrade to v7.\n\nUpgrading from v6 to v7 introduces some breaking changes and requires state migration before deploying. Refer to the SST release notes and the Pulumi migration guide to make the relevent changes before deploying: https://www.pulumi.com/registry/packages/aws/how-to-guides/7-0-migration \n\nThis notice will clear after migrating your state", |
from this message it didn't become clear that:
- the user needs to
refreshthe state - the migration is one-way only? (i tried going back and it didn't work)
|
|
||
| In this example, we'll create a cluster that can autoscales based on a custom | ||
| metric; in this case, the number of messages in a queue. | ||
| In this example, we'll create a cluster that autoscales based on a custom |
There was a problem hiding this comment.
i believe the changes made to the examples.mdx file will be lost because it gets regenerated from every JSDocs found above the sst.config.ts inside the examples/ folder
4 participants
AWS provider upgade has some breaking changes which requires some manual intervention before the user should deploy using the new version.
The steps are explained here https://www.pulumi.com/registry/packages/aws/how-to-guides/7-0-migration
Upgrade pulumi to latest version (this contains the new arg flag --run-program for refresh). (Thanks to @abnud11)This will be merged separately in another PR.sst difforsst deploy. Which asks the user to explicitly runsst refreshto migrate their state to the new version. Deploy/diff will be blocked until this is done and no resources in your state are using an outdated version.--run-programpulumi arg to refresh command, which allows the refresh to update the provider in the state.